Skip to content

do not use 'colon' sign in the iSerialNumber field of USB descriptor#7225

Merged
SuGlider merged 2 commits into
espressif:masterfrom
lyusupov:master
Dec 8, 2022
Merged

do not use 'colon' sign in the iSerialNumber field of USB descriptor#7225
SuGlider merged 2 commits into
espressif:masterfrom
lyusupov:master

Conversation

@lyusupov
Copy link
Copy Markdown
Contributor

@lyusupov lyusupov commented Sep 5, 2022

Description of Change

Most of USB devices on the market do not use 'colon' sign as a separator in the iSerialNumber field of USB descriptor.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 5, 2022

CLA assistant check
All committers have signed the CLA.

@lyusupov
Copy link
Copy Markdown
Contributor Author

@me-no-dev Thank you for approving my Pull Request!
Is there any chance to merge it soon?

@me-no-dev
Copy link
Copy Markdown
Member

Yes :) let me ping @SuGlider for an extra approval here ;)

@me-no-dev me-no-dev requested a review from SuGlider November 11, 2022 09:38
@VojtechBartoska VojtechBartoska added this to the 2.0.6 milestone Nov 16, 2022
@lyusupov
Copy link
Copy Markdown
Contributor Author

lyusupov commented Dec 2, 2022

@SuGlider SuGlider merged commit 9b88092 into espressif:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

5 participants